filling layout by NHNam96 · Pull Request #91 · hellovietnam93/Ruby_k59

NHNam96 · 2017-03-21T06:21:57Z

No description provided.

hellovietnam93 · 2017-03-21T06:28:17Z

.gitignore


 /config/locales/database.yml.example
 /config/locales/secrets.yml
+


file này k có j thay đổi em checkout ra khỏi pull giúp anh nhé

checkout ra khỏi pull là như nào a?

hellovietnam93 · 2017-03-21T06:28:26Z

Gemfile

@@ -10,6 +10,8 @@ end
 gem 'rails', '~> 5.0.2'
 # Use sqlite3 as the database for Active Record
 gem 'sqlite3'


sử dụng nháy kép cho tất cả em nhé

hellovietnam93 · 2017-03-21T06:28:36Z

Gemfile

@@ -10,6 +10,8 @@ end
 gem 'rails', '~> 5.0.2'
 # Use sqlite3 as the database for Active Record


xóa tất cả commetn trong file này giúp anh nhé

hellovietnam93 · 2017-03-21T06:28:43Z

app/assets/javascripts/static_pages.coffee

@@ -0,0 +1,3 @@
+# Place all the behaviors and hooks related to the matching controller here.


file này k dùng em xóa đi nhé

hellovietnam93 · 2017-03-21T06:28:50Z

app/assets/stylesheets/static_pages.scss

@@ -0,0 +1,3 @@
+// Place all the styles related to the StaticPages controller here.


file này cũng k dùng nhé

hellovietnam93 · 2017-03-21T06:30:19Z

app/views/layouts/application.html.erb

    <%= csrf_meta_tags %>
-
-    <%= stylesheet_link_tag    'application', media: 'all', 'data-turbolinks-track': 'reload' %>
+    <%= stylesheet_link_tag    'application', media: 'all',


sử dụng nháy kép, 1 dấu cách để ngăn thôi nhé

hellovietnam93 · 2017-03-21T06:30:24Z

app/views/layouts/application.html.erb

+        <%= link_to "sample app", '#', id: "logo" %>
+        <nav>
+          <ul class="nav navbar-nav navbar-right">
+            <li><%= link_to "Home",   '#' %></li>


tương tự bên trên

hellovietnam93 · 2017-03-21T06:30:30Z

app/views/static_pages/help.html.erb

@@ -0,0 +1,9 @@
+<% provide(:title, "Help") %>


hellovietnam93 · 2017-03-21T06:30:37Z

app/views/static_pages/home.html.erb

+
+<%= link_to image_tag("rails.png", alt: "Rails logo"),
+            'http://rubyonrails.org/' %>
+


xóa dòng này đi k đẻ làm j cả

hellovietnam93 · 2017-03-21T06:30:40Z

app/views/static_pages/home.html.erb

+</div>
+
+<%= link_to image_tag("rails.png", alt: "Rails logo"),
+            'http://rubyonrails.org/' %>


hellovietnam93 · 2017-03-21T09:26:56Z

.gitignore

 # Ignore Byebug command history file.
 .byebug_history
- 
+


checkout file này ra khỏi pull

hellovietnam93 · 2017-03-21T09:27:11Z

app/assets/stylesheets/custom.scss

+}
+
+
+


chỉ dugnf 1 dòng để ngăn cách thôi nhé xóa 2 dòng đi

hellovietnam93 · 2017-03-21T09:27:20Z

app/helpers/application_helper.rb

@@ -1,2 +1,11 @@
 module ApplicationHelper
+
+  def full_title(page_title = '')


xóa () + sử dụng nháy kép

hellovietnam93 · 2017-03-21T09:27:32Z

app/views/layouts/application.html.erb

-
-    <%= stylesheet_link_tag    'application', media: 'all', 'data-turbolinks-track': 'reload' %>
-    <%= javascript_include_tag 'application', 'data-turbolinks-track': 'reload' %>
+    <%= stylesheet_link_tag    "application", media: "all",


1 dấu cashc để ngăn sau cái tag kìa em ơi

hellovietnam93 · 2017-03-21T09:27:41Z

app/views/layouts/application.html.erb

-    <%= stylesheet_link_tag    'application', media: 'all', 'data-turbolinks-track': 'reload' %>
-    <%= javascript_include_tag 'application', 'data-turbolinks-track': 'reload' %>
+    <%= stylesheet_link_tag    "application", media: "all",
+                                              "data-turbolinks-track": "reload" %>


ident, lùi so với đầu dòng nhé

hellovietnam93 · 2017-03-21T09:28:09Z

app/views/static_pages/home.html.erb

+</div>
+
+<%= link_to image_tag("rails.png", alt: "Rails logo"),
+  'http://rubyonrails.org/' %>


hellovietnam93 · 2017-03-21T09:28:21Z

config/database.yml

@@ -0,0 +1,25 @@
+# SQLite version 3.x


file này cho vào gitignore mà, k pushs nó lên em ơi

hellovietnam93 · 2017-03-21T09:28:28Z

config/routes.rb

@@ -1,3 +1,6 @@
 Rails.application.routes.draw do
-  # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html
+  root 'static_pages#home'


hellovietnam93 · 2017-03-21T09:28:37Z

config/routes.rb

 Rails.application.routes.draw do
-  # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html
+  root 'static_pages#home'
+  get  'static_pages/home'


1 dấu cách để ngăn như viết WORD em ơi

hellovietnam93 · 2017-03-21T09:28:44Z

config/routes.rb~

@@ -0,0 +1,7 @@
+Rails.application.routes.draw do


file này xóa đi bị ooix rồi

hellovietnam93 · 2017-03-21T16:18:01Z

app/views/layouts/application.html.erb

 <html>
  <head>
-    <title>RubyK59</title>
+    <title><%= full_title(yield(:title)) %></title>


xóa hết ()

hellovietnam93 reviewed Mar 21, 2017

View reviewed changes

NHNam96 force-pushed the filling-in-layout branch from 1cf62f9 to 7414fe6 Compare March 21, 2017 09:11

hellovietnam93 reviewed Mar 21, 2017

View reviewed changes

filling layout

b85aee3

NHNam96 force-pushed the filling-in-layout branch from 7414fe6 to b85aee3 Compare March 21, 2017 10:32

hellovietnam93 reviewed Mar 21, 2017

View reviewed changes


		/config/locales/database.yml.example
		/config/locales/secrets.yml

		@@ -10,6 +10,8 @@ end
		gem 'rails', '~> 5.0.2'
		# Use sqlite3 as the database for Active Record

		@@ -0,0 +1,3 @@
		# Place all the behaviors and hooks related to the matching controller here.

		@@ -0,0 +1,3 @@
		// Place all the styles related to the StaticPages controller here.


		<%= link_to image_tag("rails.png", alt: "Rails logo"),
		'http://rubyonrails.org/' %>

		@@ -1,2 +1,11 @@
		module ApplicationHelper

		def full_title(page_title = '')

Comments

Conversation

NHNam96 commented Mar 21, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants